Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example for QB delete and update in doc block #6394

Merged
merged 1 commit into from
May 14, 2024

Conversation

Metabor
Copy link
Contributor

@Metabor Metabor commented May 14, 2024

Q A
Type bug
Fixed issues wrong documentation

Summary

$alias parameter in update() and delete() was removed in version 4 but the example still use the second parameter. Example was updated in this PR

$alias parameter in update() and delete() was removed in version 4 but the example still use the second parameter.
Example was updated in this PR
@SenseException SenseException merged commit 7fb714b into doctrine:4.0.x May 14, 2024
77 checks passed
@greg0ire greg0ire added this to the 4.0.3 milestone May 14, 2024
derrabus pushed a commit that referenced this pull request Jul 16, 2024
<!-- Fill in the relevant information below to help triage your pull
request. -->

|      Q       |   A
|------------- | -----------
| Type         | bug/improvement
| Fixed issues | Incorrect & inconsistent QueryBuilder documentation for
aliases in update/delete

#### Summary

In #6394 the documentation was partially updated to remove aliases for
the documentation for the update method, as the separate parameter for
it was removed in the upgrade from 3.x to 4.x.

Inline aliasing is still possible, and I suspect this was the reason the
extra parameter was removed. ( `->update('users alias1', 'alias2')`)?

This PR readds the alias to the documentation for the occurences in the
linked PR, and also updates the other occurences in docblocks + the
online documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants